Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required stake to confirmation_quorum #1816

Merged
merged 2 commits into from Mar 11, 2019

Conversation

@cryptocode
Copy link
Collaborator

commented Mar 10, 2019

The rules for effective stake required for quorum may change and isn't obvious from the output of confirmation_quorum (it's the largest of online_weight_minimum and quorum_delta)

Adding peers_stake_required to make this obvious and allow for future changes to the rules without breaking clients.

@cryptocode cryptocode added this to the V19.0 milestone Mar 10, 2019

@cryptocode cryptocode self-assigned this Mar 10, 2019

@cryptocode cryptocode requested a review from SergiySW Mar 10, 2019

@cryptocode cryptocode added this to CP1 (2019-03-13) in V19 Mar 10, 2019

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Mar 10, 2019

Should it also be converted with .convert_tostd::string () ?

@cryptocode

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 10, 2019

@SergiySW it's not necessary, but I can add it to be consistent.
edit: added

cryptocode added some commits Mar 10, 2019

@cryptocode cryptocode force-pushed the cryptocode:peers_stake_required branch from 9b8fcab to 032dd6b Mar 11, 2019

@cryptocode cryptocode merged commit d76431d into nanocurrency:master Mar 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:peers_stake_required branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.