Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC 100-continue and max request size #1819

Merged
merged 2 commits into from Mar 14, 2019

Conversation

@cryptocode
Copy link
Collaborator

commented Mar 11, 2019

Closes #1671

We've had reports of RPC requests sometimes taking 1 second before being handled. Some clients, such as curl (and Python wrappers), sends an Expect: 100-continue header for large requests (per rfc7231). These clients typically wait one second for the header response before sending the body (a workaround in curl is to use -H Expect:)

The PR also adds the ability to restrict request body sizes via config.json. The proposed default limit is 32MB (this must be large enough for services - opinions welcome)

@cryptocode cryptocode added this to the V19.0 milestone Mar 11, 2019

@cryptocode cryptocode self-assigned this Mar 11, 2019

@cryptocode cryptocode requested review from argakiig and SergiySW Mar 11, 2019

@cryptocode cryptocode added this to CP2 (2019-03-27) in V19 Mar 11, 2019

@cryptocode cryptocode force-pushed the cryptocode:rpc-expect-100 branch from 1d4b7db to 8d17714 Mar 13, 2019

@cryptocode cryptocode force-pushed the cryptocode:rpc-expect-100 branch from 8d17714 to fdc7e0e Mar 13, 2019

@cryptocode cryptocode removed the incomplete label Mar 13, 2019

@cryptocode cryptocode merged commit 9e71239 into nanocurrency:master Mar 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:rpc-expect-100 branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.