Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating the concepts of: #1835

Merged
merged 1 commit into from Mar 16, 2019

Conversation

2 participants
@clemahieu
Copy link
Collaborator

commented Mar 16, 2019

  • Purging the peer_container
  • Sending keepalives to nodes we haven't heard from
  • Signaling the disconnect observer

This makes the logic around each easier to reason around and movable to different portions of the code.

Separating the concepts of:
- Purging the peer_container
- Sending keepalives to nodes we haven't heard from
- Signaling the disconnect observer

This makes the logic around each easier to reason around and movable to different portions of the code.

@zhyatt zhyatt added the enhancement label Mar 16, 2019

@zhyatt zhyatt added this to the V19.0 milestone Mar 16, 2019

@clemahieu clemahieu merged commit 2124254 into master Mar 16, 2019

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@clemahieu clemahieu deleted the moving_disconnect_observer branch Mar 20, 2019

@zhyatt zhyatt added this to CP2 (2019-03-27) in V19 Mar 21, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Separating the concepts of: (nanocurrency#1835)
- Purging the peer_container
- Sending keepalives to nodes we haven't heard from
- Signaling the disconnect observer

This makes the logic around each easier to reason around and movable to different portions of the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.