Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket support #1840

Merged
merged 2 commits into from Mar 23, 2019

Conversation

@cryptocode
Copy link
Collaborator

commented Mar 17, 2019

Adds support for notifications via Websockets. This offers a more efficient callback mechanism for block confirmations, and allows for multiple listeners. As it's topic-based, filtering and additional events can be added in the future. Proper JSON is returned (the http callback returns stringified blocks). Comments on message formatting are most welcome. Note that the http callback is still supported.

Preliminary docs: https://github.com/cryptocode/notes/wiki/Websocket-support
Sample nodejs client: https://github.com/cryptocode/nano-websocket-sample-nodejs

@cryptocode cryptocode added this to the V19.0 milestone Mar 17, 2019

@cryptocode cryptocode self-assigned this Mar 17, 2019

@cryptocode cryptocode added this to CP2 (2019-03-27) in V19 Mar 17, 2019

@cryptocode cryptocode removed the incomplete label Mar 18, 2019

@cryptocode cryptocode force-pushed the cryptocode:ws-callback branch from 98d0f8f to ed24fcd Mar 19, 2019

Show resolved Hide resolved nano/node/websocket.cpp
Show resolved Hide resolved nano/node/websocket.cpp Outdated
Show resolved Hide resolved nano/node/websocket.cpp Outdated
Show resolved Hide resolved nano/node/websocket.cpp Outdated
Show resolved Hide resolved nano/node/node.cpp Outdated
Fix locking, add bind address to config, alwayts pop front message, s…
…tartup logging and optimize for likely errocode path

@cryptocode cryptocode force-pushed the cryptocode:ws-callback branch from ed24fcd to 9ed979c Mar 23, 2019

@cryptocode cryptocode merged commit fa67646 into nanocurrency:master Mar 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:ws-callback branch Mar 23, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Websocket support (nanocurrency#1840)
* Websocket support

* Fix locking, add bind address to config, alwayts pop front message, startup logging and optimize for likely errocode path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.