Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in tcp_listener_timeout_keepalive #1850

Conversation

@cryptocode
Copy link
Collaborator

commented Mar 22, 2019

There was a race causing tcp_listener_timeout_keepalive to fail intermittently. The issue is that async_write's handler is sometimes called before the visitor is called in bootstrap. Effect is connected == true, but connections.size () is still zero.

Fixed by waiting for the keepalive stat to be updated.

@cryptocode cryptocode added this to the V19.0 milestone Mar 22, 2019

@cryptocode cryptocode self-assigned this Mar 22, 2019

@cryptocode cryptocode requested a review from argakiig Mar 22, 2019

@cryptocode cryptocode added this to CP2 (2019-03-27) in V19 Mar 23, 2019

@cryptocode cryptocode merged commit 66be6b4 into nanocurrency:master Mar 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:unittest/tcp_listener_timeout_keepalive-fix branch Mar 23, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.