Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe encoding in IPC #1851

Merged
merged 1 commit into from Apr 14, 2019

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented Mar 23, 2019

Enables wallet_seed over a new IPC encoding. In addition to clients using the new encoding, a config flag must be set on each transport the client wants to use for this.

Based on #949 (only wallet_seed is used for now) and #1716

@cryptocode cryptocode added this to the V19.0 milestone Mar 23, 2019

@cryptocode cryptocode self-assigned this Mar 23, 2019

@cryptocode cryptocode requested a review from clemahieu Mar 23, 2019

@cryptocode cryptocode added this to CP2 (2019-03-27) in V19 Mar 23, 2019

@cryptocode cryptocode force-pushed the cryptocode:ipc/seed branch from e100b1a to 487b099 Apr 5, 2019

Show resolved Hide resolved nano/rpc/rpc_handler.cpp
Show resolved Hide resolved nano/node/rpc.cpp Outdated
Unsafe encoding in IPC
Co-authored-by: Sergey Kroshnin <sergiysw@gmail.com>
Co-authored-by: Devin Alexander Torres <d@devinus.io>

@cryptocode cryptocode force-pushed the cryptocode:ipc/seed branch from 487b099 to 31f056e Apr 11, 2019

@cryptocode cryptocode merged commit e811971 into nanocurrency:master Apr 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:ipc/seed branch Apr 14, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Unsafe encoding in IPC (nanocurrency#1851)
Co-authored-by: Sergey Kroshnin <sergiysw@gmail.com>
Co-authored-by: Devin Alexander Torres <d@devinus.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.