Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend lifetime of size response in rpc handler #1859

Merged
merged 2 commits into from Mar 25, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Mar 25, 2019

As size_response is declared on the stack it may go out of scope before the async_write completion handler is called.

@wezrule wezrule added the bug label Mar 25, 2019

@wezrule wezrule added this to the V19.0 milestone Mar 25, 2019

@wezrule wezrule self-assigned this Mar 25, 2019

@wezrule wezrule requested a review from cryptocode Mar 25, 2019

@wezrule wezrule merged commit b3c7ad2 into nanocurrency:master Mar 25, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@wezrule wezrule added this to CP2 (2019-03-27) in V19 Mar 26, 2019

@wezrule wezrule deleted the wezrule:extend_size_lifetime branch Apr 4, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Extend lifetime of size response in rpc handler (nanocurrency#1859)
* Extend lifetime of size response in rpc handler

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.