Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to load tester script #1861

Merged
merged 1 commit into from Mar 26, 2019

Conversation

3 participants
@wezrule
Copy link
Collaborator

commented Mar 25, 2019

These are just some things I noticed while looking at this area. When testing with small send counts this error message sometimes appeared:

Error: failed to check account xrb_31sstakuod4x3kkeiibi39hand6mgrtsmbmetwe8t9y7azgfirxp9m9u1crb info on primary node
  caused by: Account not found

This is because sends are sent randomly to accounts, so it's possible that an account doesn't get a send so the account_info won't exist in the database when trying to find it afterwards. I now make sure that every account gets at least one send (although gave up trying to do it efficiently as I'm not familiar with Rust). From speaking to other members of the team, no one is that familiar with Rust so I think it would be good to re-write this into something else more like Python.

@wezrule wezrule added the tool label Mar 25, 2019

@wezrule wezrule added this to the V19.0 milestone Mar 25, 2019

@wezrule wezrule self-assigned this Mar 25, 2019

@wezrule wezrule requested a review from argakiig Mar 25, 2019

@zhyatt zhyatt added this to CP2 (2019-03-27) in V19 Mar 25, 2019

@wezrule wezrule merged commit 2c35fe8 into nanocurrency:master Mar 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:updates_to_load_tester branch Mar 26, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.