Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor coding style updates #1863

Merged
merged 4 commits into from Mar 26, 2019

Conversation

@wezrule
Copy link
Collaborator

commented Mar 25, 2019

Didn't check every single case, but have modified things like like:
final on leaf concrete classes
Replacing typedef with using aliases.
explicit constructors for constructors with 1 argument.
Using in-class initialization instead of having a default constructor
Removing unused variables/functions

@wezrule wezrule added this to the V19.0 milestone Mar 25, 2019

@wezrule wezrule self-assigned this Mar 25, 2019

@wezrule wezrule requested a review from argakiig Mar 25, 2019

@zhyatt zhyatt added this to CP2 (2019-03-27) in V19 Mar 25, 2019

@clemahieu
Copy link
Collaborator

left a comment

Great cleanup.

@wezrule wezrule merged commit dd8a810 into nanocurrency:master Mar 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:coding_style_updates branch Mar 26, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Various minor coding style updates (nanocurrency#1863)
* Various coding style updates

* Remove unnecessary change to blocks.cpp

* Formatting

* Re-add necessary node_config default constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.