Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependency between secure <-> lib libraries #1867

Merged

Conversation

@wezrule
Copy link
Collaborator

commented Mar 27, 2019

This PR removes any mention of secure in the lib library. The secure library has a few dependencies on the lib library, while the lib library currently has a dependency on the keypair class which is part of the secure library (which also currently has circular dependencies with the node library), this was part of a larger class network_params. A lot of this code used to be in the secure library before, so I've just moved it back. However it is necessary to know logic like which network we are on (test/live/beta) in the future RPC stuff so a new class network_constants has been created which incorporates this in the lib library.

@wezrule wezrule added this to the V19.0 milestone Mar 27, 2019

@wezrule wezrule self-assigned this Mar 27, 2019

@wezrule wezrule requested a review from cryptocode Mar 27, 2019

@clemahieu
Copy link
Collaborator

left a comment

Perfect, a much needed untangling.

@cryptocode
Copy link
Collaborator

left a comment

Splendid

@wezrule

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 27, 2019

Thanks!

@wezrule wezrule merged commit c45bfae into nanocurrency:master Mar 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:split_secure_and_lib_dependencies branch Mar 27, 2019

@wezrule wezrule added this to CP2 (2019-03-27) in V19 Mar 27, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.