Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ed25519 and lib library circular dependency #1870



Copy link

commented Mar 27, 2019

We declare our own custom ed25519 functions in nano/lib/interface.cpp which the ed25519 library is dependent on, however we also use ed25519 functions inside the lib library, so to resolve this circular dependency I have created a new library crypto_lib for lack of a better name which extracts the custom ed25519 function definitions and also a class it is dependent on random_pool.

@wezrule wezrule added this to the V19.0 milestone Mar 27, 2019

@wezrule wezrule self-assigned this Mar 27, 2019

@wezrule wezrule requested review from cryptocode and clemahieu Mar 27, 2019

@wezrule wezrule merged commit 6ef586b into nanocurrency:master Mar 27, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
continuous-integration/appveyor/pr AppVeyor build succeeded

@wezrule wezrule deleted the wezrule:remove_ed25519_lib_circular_dependency branch Mar 27, 2019

@wezrule wezrule added this to CP2 (2019-03-27) in V19 Mar 27, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.