Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor preparation for moving RPC out of process #1872

Merged
merged 4 commits into from Mar 28, 2019

Conversation

@wezrule
Copy link
Collaborator

commented Mar 27, 2019

Move RPC classes to a new subfolder nano/rpc and also create a few different files to hold the related clases in. It currently depends on the node library (and vice versa) but this dependency will be removed in the main RPC task. Also moved the rpc tests to their own executable.
Extracted a few other things like thread_runner, logging, ipc_client/transport etc.. to the lib library to make them accessible to other libraries which won't have access to the node library (e.g the new RPC server process).

@wezrule wezrule added this to the V19.0 milestone Mar 27, 2019

@wezrule wezrule self-assigned this Mar 27, 2019

@wezrule wezrule requested review from clemahieu and cryptocode Mar 27, 2019

@cryptocode
Copy link
Collaborator

left a comment

Minor formatting issue on CI, otherwise LGTM

@wezrule

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 28, 2019

Thanks :)

@wezrule wezrule merged commit 7e405d9 into nanocurrency:master Mar 28, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@wezrule wezrule deleted the wezrule:rpc_prep branch Mar 28, 2019

@zhyatt zhyatt added this to CP3 (2019-04-10) in V19 Mar 28, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Refactor preparation for moving RPC out of process (nanocurrency#1872)
* Move things around preparing for RPC out of process

* Add rpc_test executable for testing rpc commands

* Add rpc_test to ci

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.