Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSAN: fix races in udp channels #1873

Merged
merged 2 commits into from Mar 29, 2019

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented Mar 28, 2019

TSAN reported races in socket usage as well as unlocked access to the channels container in max_ip_connections

The call to channels.socket.async_send_to has been encapsulated in udp_channels (so the caller doesn't have to know about the mutex)

@cryptocode cryptocode self-assigned this Mar 28, 2019

@cryptocode cryptocode added this to the V19.0 milestone Mar 28, 2019

@cryptocode cryptocode added this to CP3 (2019-04-10) in V19 Mar 28, 2019

@cryptocode cryptocode requested a review from wezrule Mar 28, 2019

@cryptocode cryptocode added sanitizers and removed incomplete labels Mar 28, 2019

@cryptocode cryptocode merged commit d015324 into nanocurrency:master Mar 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:fix/udp-race-conditions branch Mar 29, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

TSAN: fix races in udp channels (nanocurrency#1873)
* TSAN: fix races in udp channels

* Encapsulate async_send_to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.