Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When clearing confirmation heights set the genesis account to be 1 #1875

Merged

Conversation

3 participants
@wezrule
Copy link
Collaborator

commented Mar 29, 2019

In mdb_store::initialize we now set the genesis account's open block as being confirmed (which makes sense). When clearing the confirmation heights we probably want the genesis account to go to 1 rather than 0 which is what this PR does.

@wezrule wezrule added this to the V19.0 milestone Mar 29, 2019

@wezrule wezrule self-assigned this Mar 29, 2019

@wezrule wezrule requested a review from clemahieu Mar 29, 2019

@wezrule wezrule added this to CP3 (2019-04-10) in V19 Mar 29, 2019

@wezrule wezrule closed this Apr 4, 2019

@wezrule wezrule deleted the wezrule:clear_confirmation_heights_genesis_1 branch Apr 4, 2019

@zhyatt zhyatt removed this from CP3 (2019-04-10) in V19 Apr 4, 2019

@zhyatt zhyatt removed this from the V19.0 milestone Apr 4, 2019

@wezrule wezrule restored the wezrule:clear_confirmation_heights_genesis_1 branch Apr 4, 2019

@wezrule wezrule reopened this Apr 4, 2019

@wezrule

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 4, 2019

whoops, closed in error

@wezrule wezrule added this to the V19.0 milestone Apr 4, 2019

@wezrule wezrule requested review from SergiySW and removed request for clemahieu Apr 5, 2019

@wezrule wezrule merged commit 98d04d2 into nanocurrency:master Apr 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt added this to CP3 (2019-04-10) in V19 Apr 7, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

When clearing confirmation heights set the genesis account to be 1 (n…
…anocurrency#1875)

* When clearing confirmation heights set the genesis account to have 1

* Formatting

@wezrule wezrule deleted the wezrule:clear_confirmation_heights_genesis_1 branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.