Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsan: Fix race in repcrawler and remove redundant weight computation #1881

merged 1 commit into from Apr 7, 2019


2 participants
Copy link

commented Apr 7, 2019

The unlocked version of total_weight() was called where a lock is needed. Weight was also computed twice, now it's passed as an argument.

@cryptocode cryptocode added this to the V19.0 milestone Apr 7, 2019

@cryptocode cryptocode self-assigned this Apr 7, 2019

@cryptocode cryptocode requested a review from argakiig Apr 7, 2019

@cryptocode cryptocode added this to CP3 (2019-04-10) in V19 Apr 7, 2019

@cryptocode cryptocode merged commit 9342c83 into nanocurrency:master Apr 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@cryptocode cryptocode deleted the cryptocode:fix/repcrawler-race branch Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.