Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce work.eco_pow intermittent failure rate #1882

Merged

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Apr 7, 2019

Due to the random nature of a successful proof when generating pow this test can fail when comparing the time taken for 2 threads to find a valid proof even when 1 thread has a delay. I have made this delay more pronounced, which does increase the time taken to complete the test (100ms on my machine), but it seems worthwhile to do this to cause it to fail even more infrequently (pretty much 0)

@wezrule wezrule added the enhancement label Apr 7, 2019

@wezrule wezrule added this to the V19.0 milestone Apr 7, 2019

@wezrule wezrule self-assigned this Apr 7, 2019

@wezrule wezrule requested a review from cryptocode Apr 7, 2019

Show resolved Hide resolved nano/core_test/work_pool.cpp Outdated

@zhyatt zhyatt added this to CP3 (2019-04-10) in V19 Apr 7, 2019

@wezrule wezrule merged commit 91ee07a into nanocurrency:master Apr 8, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@wezrule wezrule deleted the wezrule:fix_intermittent_work_eco_pow_failure branch Apr 8, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Reduce work.eco_pow intermittent failure rate (nanocurrency#1882)
* Reduce work.eco_pow intermittent failure rate

* Change to milliseconds to improve readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.