Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Create new node ID on each launch & support keepalive with preferred ports #1885
cryptocode left a comment •
Some projects allow setting the external ip and port in config/cmdline options, instead of relying on upnp / nat-pmp. Maybe we should support that (if set, disable upnp)? Probably need future research/another PR so approving this.
@SergiySW yes indeed, I once suggested we'd do a curlmyip-ish implementation in the node - you'd query the preconfigured nodes to get the external ip. But because of various NAT setups, some projects allows you to specify external port manually (in addition to external ip).