Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new node ID on each launch & support keepalive with preferred ports #1885

Merged
merged 17 commits into from Apr 16, 2019

Conversation

@SergiySW
Copy link
Collaborator

commented Apr 8, 2019

No description provided.

@SergiySW SergiySW added the enhancement label Apr 8, 2019

@SergiySW SergiySW self-assigned this Apr 8, 2019

@SergiySW SergiySW changed the title Create new node ID with each node launch Create new node ID on each node launch Apr 8, 2019

@zhyatt zhyatt added this to the V19.0 milestone Apr 8, 2019

@zhyatt zhyatt added this to CP3 (2019-04-10) in V19 Apr 9, 2019

@SergiySW SergiySW changed the title Create new node ID on each node launch Create new node ID on each launch & support keepalive with preferred ports Apr 9, 2019

@SergiySW SergiySW requested review from cryptocode and wezrule Apr 10, 2019

@cryptocode
Copy link
Collaborator

left a comment

Some projects allow setting the external ip and port in config/cmdline options, instead of relying on upnp / nat-pmp. Maybe we should support that (if set, disable upnp)? Probably need future research/another PR so approving this.

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 10, 2019

@cryptocode some projects also discover own peer IP with web services / other peers

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

@SergiySW yes indeed, I once suggested we'd do a curlmyip-ish implementation in the node - you'd query the preconfigured nodes to get the external ip. But because of various NAT setups, some projects allows you to specify external port manually (in addition to external ip).

@SergiySW SergiySW requested a review from cryptocode Apr 12, 2019

Show resolved Hide resolved nano/node/node.cpp Outdated

@zhyatt zhyatt requested a review from clemahieu Apr 15, 2019

@SergiySW SergiySW merged commit 1701882 into nanocurrency:master Apr 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.