Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port config cleanup, allow running tests alongside beta node #1891

Merged
merged 1 commit into from Apr 10, 2019

Conversation

@cryptocode
Copy link
Collaborator

commented Apr 10, 2019

beta and test nets currently share default port numbers, which makes rpc and other tests fail if a beta node or wallet is running. Also makes use of network_constants for ipc and websockets.

@cryptocode cryptocode added this to the V19.0 milestone Apr 10, 2019

@cryptocode cryptocode self-assigned this Apr 10, 2019

@cryptocode cryptocode requested a review from SergiySW Apr 10, 2019

@cryptocode cryptocode merged commit 8e2e127 into nanocurrency:master Apr 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:port-number-cleanup branch Apr 10, 2019

@zhyatt zhyatt added this to CP3 (2019-04-10) in V19 Apr 10, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.