Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TSAN warning with work.eco_pow #1893

Merged
merged 1 commit into from Apr 12, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Apr 10, 2019

This is a test I wrote, and wanted to try use set_value_at_thread_exit as I hadn't used it before. However it raised a TSAN warning when calling future.get (). I tried various things, but it seems that the thread needs to be finished before get () is called on the future, despite the example not doing this https://en.cppreference.com/w/cpp/thread/promise/set_value_at_thread_exit. I could simply just use set_value, but that's no fun :), and it at least shows an example of the apparent correct usage should someone require it in the future.

@wezrule wezrule added the sanitizers label Apr 10, 2019

@wezrule wezrule added this to the V19.0 milestone Apr 10, 2019

@wezrule wezrule requested a review from SergiySW Apr 10, 2019

@wezrule wezrule self-assigned this Apr 10, 2019

@wezrule wezrule changed the title Fix TSAN error with work.eco_pow Fix TSAN warning with work.eco_pow Apr 10, 2019

@wezrule wezrule added this to CP3 (2019-04-10) in V19 Apr 10, 2019

@SergiySW
Copy link
Collaborator

left a comment

LGTM

@wezrule wezrule merged commit e63a5bd into nanocurrency:master Apr 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:fix_tsan_work_eco_pow branch Apr 12, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.