Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TSAN warning in node.no_voting & wallet.update_work_action #1894

Merged
merged 7 commits into from Apr 26, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Apr 10, 2019

In active::confirmed_frontiers (), enable_voting is used but this is accessed at the same time it is set in node.no_voting. It seemed a bit pointless to add a mutex to protect enable_voting as it is only changed in tests (other than during node initialization), and this creates other problems as the node_config will need an explicit copy constructor as the mutex implicitly deletes it, so will need to be a mutable mutex and all the data members (there is a lot) would need setting and maintaining, just for tests, it didn't seem worth it.

@wezrule wezrule added the sanitizers label Apr 10, 2019

@wezrule wezrule added this to the V19.0 milestone Apr 10, 2019

@wezrule wezrule requested a review from argakiig Apr 10, 2019

@wezrule wezrule self-assigned this Apr 10, 2019

@wezrule wezrule added this to CP3 (2019-04-10) in V19 Apr 10, 2019

@wezrule wezrule requested a review from argakiig Apr 23, 2019

@wezrule

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 23, 2019

@argakiig I've updated this a bit, so that we can customize nodes in the tests a bit easier and don't have to have dummy ones sitting around.

@zhyatt zhyatt moved this from CP3 (2019-04-10) to During RC in V19 Apr 23, 2019

@wezrule wezrule changed the title Fix TSAN warning in node.no_voting Fix TSAN warning in node.no_voting & wallet.update_work_action Apr 26, 2019

@wezrule wezrule merged commit 6197774 into nanocurrency:master Apr 26, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@wezrule wezrule deleted the wezrule:fix_tsan_error_node_no_votes branch Apr 26, 2019

@zhyatt zhyatt moved this from During RC to RC2 (2019-05-06) in V19 May 6, 2019

@zhyatt zhyatt moved this from RC2 (2019-05-06) to CP3/RC 1 (2019-04-26) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.