Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused rpc.cpp #1897

Merged
merged 1 commit into from Apr 11, 2019

Conversation

2 participants
@SergiySW
Copy link
Collaborator

commented Apr 11, 2019

No description provided.

@SergiySW SergiySW added this to the V19.0 milestone Apr 11, 2019

@SergiySW SergiySW requested a review from wezrule Apr 11, 2019

@SergiySW SergiySW self-assigned this Apr 11, 2019

@zhyatt zhyatt added this to CP3 (2019-04-10) in V19 Apr 11, 2019

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

I did fix this in #1874, however it's not in yet and is good to get this removed as it's annoying. It should be removed from CMakeLists.txt file as well though

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 11, 2019

@wezrule this file (nano/node/rpc.cpp) is not deleted in #1874. Also it's not referenced in any CMakeLists.txt

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

Oh, sorry I thought this was rpc.cpp in the core_test which is also duplicated, fancy removing it as well here?

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 11, 2019

Well, removing core_test/rpc.cpp is already part of #1874

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

Yeh, but still annoying in the meantime :), no worries

@SergiySW SergiySW merged commit 1d0afdb into nanocurrency:master Apr 11, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.