Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Update confirmation heights with new async timing #1899
This was solved in #1877 (although have realized now it is not quite enough), but recent changes have escalated its necessity earlier.
To make sure frontiers aren't checked during the test, a new bool is passed through to active_transactions which delays the start of confirming frontiers. This is necessary because active starts in it's own thread after the node is created, so can introduce a data race which is only possible in tests so didn't want to complicate core logic with mutex etc just for it.
Also core_test/rpc.cpp this should have been removed during a previous refactor.