Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets - Fix tests breaking with TSAN #1913

Merged

Conversation

2 participants
@guilhermelawless
Copy link
Contributor

commented Apr 23, 2019

Simpler approach that creates a local io_context to call run_one_for (deadline) instead of using multiple threads with a deadline timer, avoiding data races.

Fix tests breaking with TSAN by creating a local io_context and avoid…
…ing multi threading inside the test websocket client

@cryptocode cryptocode added this to During RC in V19 Apr 24, 2019

@cryptocode cryptocode merged commit c63b673 into nanocurrency:master Apr 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt moved this from During RC to RC2 (2019-05-06) in V19 May 6, 2019

@zhyatt zhyatt moved this from RC2 (2019-05-06) to CP3/RC 1 (2019-04-26) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.