Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests and update logic of work_watcher::run() #1918

Merged
merged 1 commit into from Apr 24, 2019

Conversation

@argakiig
Copy link
Collaborator

commented Apr 24, 2019

if a block doesn't exist in the ledger its definitely not confirmed
Don't bother checking confirmation as that will assert if the block doesn't exist
Update ledger check to block_confirmed_or_being_confirmed to check ledger and confirmation_height_processor

if a block doesnt exist in the ledger its definitely not confirmed
dont bother checking confirmation as that will assert if the block doesn't exist
update ledger check to block_confirmed_or_being_confirmed to check ledger and confirmation_height_processor

@argakiig argakiig added this to the V19.0 milestone Apr 24, 2019

@argakiig argakiig requested review from wezrule and cryptocode Apr 24, 2019

@argakiig argakiig self-assigned this Apr 24, 2019

@argakiig argakiig merged commit 4fd0541 into nanocurrency:master Apr 24, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@zhyatt zhyatt added this to CP3/RC 1 (2019-04-26) in V19 Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.