Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set defaults for block_sideband #1922

Merged

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Apr 25, 2019

@cryptocode wasn't sure if if (value.mv_size != 0) inside nano::mdb_store::block_get () would be called if the block doesn't exist. nano::mdb_store::block_account_height () returns a height regardless so it could return a garbage value in release mode (in debug it asserts). So to cover this I'm setting some default for the sideband data.

@wezrule wezrule added this to the V19.0 milestone Apr 25, 2019

@wezrule wezrule requested a review from cryptocode Apr 25, 2019

@wezrule wezrule self-assigned this Apr 25, 2019

@zhyatt zhyatt added this to During RC in V19 Apr 30, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM, failing test fixed by PR1920

@wezrule wezrule merged commit 74843b8 into nanocurrency:master May 4, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@wezrule wezrule deleted the wezrule:set_defaults_for_block_sideband branch May 4, 2019

argakiig added a commit that referenced this pull request May 6, 2019

@zhyatt zhyatt moved this from During RC to RC2 (2019-05-06) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.