Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket tests: Use error_code when closing #1924

Merged

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented Apr 25, 2019

Closing may throw on Windows; any close error can be ignored in the tests.

@cryptocode cryptocode added this to the V19.0 milestone Apr 25, 2019

@cryptocode cryptocode requested a review from wezrule Apr 25, 2019

@cryptocode cryptocode self-assigned this Apr 25, 2019

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

Works good now, thanks

@cryptocode cryptocode merged commit 9010719 into nanocurrency:master Apr 25, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@cryptocode cryptocode deleted the cryptocode:websockets/test_use_error_code branch Apr 25, 2019

@zhyatt zhyatt added this to CP3/RC 1 (2019-04-26) in V19 Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.