Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new random_constants class for not_an_account #1928

Merged
merged 1 commit into from Apr 26, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Apr 25, 2019

not_an_account () is not thread-safe now, it cannot be called in the constructor of ledger_constants because there are global objects of it (and it will trigger an ASAN warning with CryptoPP globals not initialized yet). However it can just be moved out into a separate class and set in the constructor because there are relatively few users of it and they don't touch any globals. Ran ASAN on both core tests + daemon and no CryptoPP warnings.

@wezrule wezrule added this to the V19.0 milestone Apr 25, 2019

@wezrule wezrule requested a review from cryptocode Apr 25, 2019

@wezrule wezrule self-assigned this Apr 25, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM

@wezrule wezrule merged commit 55b1b14 into nanocurrency:master Apr 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:make_random_constants branch Apr 26, 2019

@zhyatt zhyatt added this to CP3/RC 1 (2019-04-26) in V19 Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.