Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some asan rpc issues #1931

Merged
merged 4 commits into from Apr 26, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Apr 25, 2019

Fixes 2 asan issues.

1 - The scope of default parameters to const refs does extend beyond the constructor, so pass it in explicitly instead (Edit: seems not to be fixed).

2 - Incorrect cast of a block in rpc.account_history

@wezrule wezrule added the sanitizers label Apr 25, 2019

@wezrule wezrule added this to the V19.0 milestone Apr 25, 2019

@wezrule wezrule self-assigned this Apr 25, 2019

@wezrule wezrule added the incomplete label Apr 25, 2019

@wezrule wezrule merged commit 0523981 into nanocurrency:master Apr 26, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@wezrule wezrule deleted the wezrule:fix_some_asan_rpc_issues branch Apr 26, 2019

@wezrule wezrule removed the incomplete label Apr 26, 2019

@zhyatt zhyatt added this to CP3/RC 1 (2019-04-26) in V19 Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.