Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSAN - Fix websocket tests #1935

Merged

Conversation

@guilhermelawless
Copy link
Contributor

commented Apr 26, 2019

All thread unsafe operations of the websocket server should go through the strand.

Shared objects: Unsafe. The application must also ensure that all asynchronous operations are performed within the same implicit or explicit strand. Boost.

But I think handshaking does not have to go through the strand.

Tested on a high end Ubuntu 18 GCC8 Boost 1.70, 300 times all websocket.* options on TSAN and ASAN separately. @cryptocode @SergiySW wonder if it still happens to you.

@cryptocode cryptocode merged commit 8b0bc71 into nanocurrency:master Apr 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@guilhermelawless guilhermelawless deleted the guilhermelawless:websockets/strand-all branch Apr 26, 2019

@zhyatt zhyatt added this to CP3/RC 1 (2019-04-26) in V19 Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.