Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix our warnings #1942

Merged
merged 3 commits into from Apr 30, 2019

Conversation

@wezrule
Copy link
Collaborator

commented Apr 27, 2019

Some more warnings have been introduced on our end

wezrule added some commits Apr 27, 2019

@wezrule wezrule added this to the V19.0 milestone Apr 27, 2019

@wezrule wezrule requested a review from argakiig Apr 27, 2019

@wezrule wezrule self-assigned this Apr 27, 2019

Show resolved Hide resolved nano/core_test/websocket.cpp Outdated

@zhyatt zhyatt added this to During RC in V19 Apr 30, 2019

@wezrule wezrule merged commit 797dfe8 into nanocurrency:master Apr 30, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@wezrule wezrule deleted the wezrule:fix_our_warnings branch Apr 30, 2019

argakiig added a commit that referenced this pull request May 6, 2019

Fix our warnings (#1942)
* Mac warnings

* MSVC warnings

* Re-enable websocket tests

@zhyatt zhyatt moved this from During RC to RC2 (2019-05-06) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.