Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression introduced by 100-continue #1949

Merged
merged 2 commits into from May 3, 2019

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented May 1, 2019

Reports of stuck RPC. Based on community reports, Wesley tracked it down to IO threads waiting for header reads to complete. All handlers run in IO threads, so lots of requests could get it stuck. Reorganized the 100-continue header handling (which solves the slow large-request problems people were having) so it no longer waits on a promise. Hopefully this fixes the issue (unable to reproduce before and after though, hopefully community members can try this PR before merge)

@cryptocode cryptocode added the bug label May 1, 2019

@cryptocode cryptocode added this to the V19.0 milestone May 1, 2019

@cryptocode cryptocode requested a review from wezrule May 1, 2019

@cryptocode cryptocode self-assigned this May 1, 2019

@cryptocode cryptocode added this to During RC in V19 May 1, 2019

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

LGTM after removing header_parser from the lambda capture in boost::beast::http::async_write
Tested using curl with and without "Expect:" (and "Expect: 100-continue" to be sure even though it's meant to be the default), worked ok

@wezrule

wezrule approved these changes May 3, 2019

@cryptocode cryptocode merged commit ba09b64 into nanocurrency:master May 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:rpc/readheader-fix branch May 3, 2019

argakiig added a commit that referenced this pull request May 6, 2019

Fix regression introduced by 100-continue (#1949)
* Fix regression introduced by 100-continue

* Remove superfluous capture

@zhyatt zhyatt moved this from During RC to RC2 (2019-05-06) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.