Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPC block_create error getting overridden #1952

Merged

Conversation

3 participants
@guilhermelawless
Copy link
Contributor

commented May 3, 2019

Bug was found during beta net testing, if any error code was set before line 1279 it would be overridden by nano::error_rpc::block_create_key_required.

Suggest hiding whitespace changes to see the diff.

@zhyatt zhyatt requested a review from wezrule May 3, 2019

@zhyatt zhyatt added the bug label May 3, 2019

@zhyatt zhyatt added this to the V19.0 milestone May 3, 2019

@zhyatt zhyatt added this to During RC in V19 May 3, 2019

@wezrule

wezrule approved these changes May 7, 2019

Copy link
Collaborator

left a comment

LGTM, thanks

@wezrule wezrule merged commit 284de4d into nanocurrency:master May 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt moved this from During RC to RC 3 (TBD) in V19 May 12, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.