Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print info about network and path, when running daemon #1953

Merged
merged 6 commits into from Jun 6, 2019

Conversation

3 participants
@guilhermelawless
Copy link
Contributor

commented May 4, 2019

After multiple human mistakes, this is my proposal.

  • Adds a active_network_label method to network_constants #1957
  • Always log active network and the application path
  • When using daemon, prints out the network, version and path

In CLI:

./nano_node --daemon --network test
Network: test, version: 20.0
Path: /home/USER/NanoTest

In log:

[2019-05-04 10:51:12.104364]: Active network: test

wezrule added a commit to wezrule/raiblocks that referenced this pull request May 6, 2019

wezrule added a commit that referenced this pull request May 6, 2019

Pass command line arguments (network/data_path) to nano_rpc child pro…
…cess (#1957)

* Pass command line args to nano_rpc

* Remove unused network_params

* Formatting

* Simplify get_current_network_as_string stealing from #1953

@guilhermelawless guilhermelawless force-pushed the guilhermelawless:daemon-cout branch from 6db9be4 to 885ee95 May 6, 2019

@guilhermelawless guilhermelawless force-pushed the guilhermelawless:daemon-cout branch from 92553aa to 510065b May 6, 2019

argakiig added a commit that referenced this pull request May 6, 2019

Pass command line arguments (network/data_path) to nano_rpc child pro…
…cess (#1957)

* Pass command line args to nano_rpc

* Remove unused network_params

* Formatting

* Simplify get_current_network_as_string stealing from #1953

@zhyatt zhyatt requested a review from wezrule May 23, 2019

@zhyatt zhyatt added this to the V19.0 milestone May 30, 2019

std::string network = "Live";
if (wallet.node.network_params.network.is_beta_network ())
std::string network = wallet.node.network_params.network.get_current_network_as_string ();
if (!network.empty ())

This comment has been minimized.

Copy link
@wezrule

wezrule May 30, 2019

Collaborator

this is probably unnecessary (overly defensive) as network will always be populated, but it's fine as well.

@zhyatt zhyatt added this to RC 4 (TBD) in V19 May 30, 2019

@wezrule wezrule merged commit 940f4ae into nanocurrency:master Jun 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

argakiig added a commit that referenced this pull request Jun 11, 2019

Print info about network and path, when running daemon (#1953)
* Print info about network and path, when running daemon

* Fix wallet build

* Use method introduced in #1957

* Fix wallet build again

* log order

@guilhermelawless guilhermelawless deleted the guilhermelawless:daemon-cout branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.