Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce length holding read transaction open for in confirmation height processor #1954

Merged

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented May 4, 2019

Using #1947 it was found that the confirmation height processor can hold a read transaction open for several minutes when traversing very long account chains. This can have impacts on the database size as any writes cannot use the pages this is holding on to until the read has finished.

Added a generic test for reset/renew on the database as one didn't exist.

Made a slight optimization which mean that the sideband data was no longer needed when reading in the blocks on an account.

@wezrule wezrule added this to the V19.0 milestone May 4, 2019

@wezrule wezrule requested a review from cryptocode May 4, 2019

@wezrule wezrule self-assigned this May 4, 2019

@wezrule wezrule changed the title Reduce time holding read transaction open for when traversing long account chains Reduce length holding read transaction open for in confirmation height processor May 4, 2019

@wezrule wezrule added this to During RC in V19 May 5, 2019

@wezrule wezrule merged commit 0c4fc6e into nanocurrency:master May 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:reduce_conf_height_read_transation_times branch May 9, 2019

@zhyatt zhyatt moved this from During RC to RC 3 (TBD) in V19 May 12, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Reduce length holding read transaction open for in confirmation heigh…
…t processor (nanocurrency#1954)

* Reduce holding read transaction open to a few seconds maximum

* Write lock shouldn't be based on number of blocks being cemented

* Reverse order of read transactions being opened in do-while loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.