Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple ledger validation CLI command #1956

Merged
merged 1 commit into from May 6, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented May 6, 2019

This add a new CLI command --debug_validate_ledger which can be used to do some simple (currently) validation of the ledger to detect any problems.

@ricki had an issue where the node was crashing but it gave no useful information. This ended up being because he opened the ledger in v18 (after syncing v19) and some accounts got added. Due to the extra confirmation_height in the account_info, the size of it inside the database was not correct which caused some error when reading.
@cryptocode had an issue using a ledger which had been used previously in-between to the change from sideband height open block being 1 from 0.

Both those (and some others) should now be detected. I'd imagine as further issues are found in the future they can be added here.

@wezrule wezrule added this to the V19.0 milestone May 6, 2019

@wezrule wezrule requested a review from SergiySW May 6, 2019

@wezrule wezrule self-assigned this May 6, 2019

@wezrule wezrule changed the title Simple ledger validation Simple ledger validation CLI command May 6, 2019

@wezrule wezrule requested review from argakiig and removed request for SergiySW May 6, 2019

@wezrule wezrule merged commit c2e0ffb into nanocurrency:master May 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:validate_ledger_cli branch May 6, 2019

@wezrule wezrule added this to During RC in V19 May 6, 2019

argakiig added a commit that referenced this pull request May 6, 2019

@zhyatt zhyatt moved this from During RC to RC2 (2019-05-06) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.