Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass command line arguments (network/data_path) to nano_rpc child process #1957

Merged
merged 4 commits into from May 6, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented May 6, 2019

When nano_rpc is used in-process it now gets passed network/data_path command line arguments so that it is in sync with nano_node should they not be the defaults.

Improve error message when rpc_path does not point to a valid file.

Removed unused network_params variables from some rpc code

@wezrule wezrule added this to the V19.0 milestone May 6, 2019

@wezrule wezrule requested a review from cryptocode May 6, 2019

@wezrule wezrule self-assigned this May 6, 2019

@wezrule wezrule changed the title Pass command line arguments for (network/data_path) to nano_rpc child process Pass command line arguments (network/data_path) to nano_rpc child process May 6, 2019

@cryptocode
Copy link
Collaborator

left a comment

If merged, #1953 should be updated to use get_current_network_as_string

@wezrule

This comment has been minimized.

Copy link
Collaborator Author

commented May 6, 2019

@cryptocode thanks. Didn't see that, but gonna steal how he has done it :)

@wezrule wezrule merged commit 3ea9c70 into nanocurrency:master May 6, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@wezrule wezrule deleted the wezrule:pass_cmd_line_args_to_nano_rpc branch May 6, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request May 6, 2019

@wezrule wezrule added this to During RC in V19 May 6, 2019

argakiig added a commit that referenced this pull request May 6, 2019

Pass command line arguments (network/data_path) to nano_rpc child pro…
…cess (#1957)

* Pass command line args to nano_rpc

* Remove unused network_params

* Formatting

* Simplify get_current_network_as_string stealing from #1953

@zhyatt zhyatt moved this from During RC to RC2 (2019-05-06) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.