Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating work_watcher::run #1960

Merged
merged 2 commits into from May 6, 2019

Conversation

2 participants
@argakiig
Copy link
Collaborator

commented May 6, 2019

update election winner and blocks when re-working

argakiig added some commits May 6, 2019

check for error codes before locking active, updating the existing el…
…ections, and then flooding blocks and updating the difficulty in roots

@argakiig argakiig requested review from wezrule and SergiySW May 6, 2019

@argakiig argakiig self-assigned this May 6, 2019

@argakiig argakiig added the bug label May 6, 2019

@argakiig argakiig added this to the V19.0 milestone May 6, 2019

@wezrule

wezrule approved these changes May 6, 2019

Copy link
Collaborator

left a comment

Look ok from what I can tell. *block.get () could just be *block on the update_difficulty line, but that was already there just moved.

@argakiig argakiig added this to CP3/RC 1 (2019-04-26) in V19 May 6, 2019

@argakiig argakiig merged commit 90c649c into nanocurrency:master May 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

argakiig added a commit that referenced this pull request May 6, 2019

updating work_watcher::run (#1960)
* check for error codes before locking active, updating the existing elections, and then flooding blocks and updating the difficulty in roots

* ensure block is found before replacing

@zhyatt zhyatt moved this from CP3/RC 1 (2019-04-26) to RC2 (2019-05-06) in V19 May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.