Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop node when using an incompatible ledger #1964

Conversation

3 participants
@wezrule
Copy link
Collaborator

commented May 7, 2019

The node should be incompatible with a future version. Currently it is possible to start a v18 node with a v19 ledger, while we cannot retrofit this to existing versions, any future ledger version will be incompatible with this one and so on.

wallet_init is unused so have gotten rid of it and pass wallets_store_init in its place.

There is a lot of unnecessary work done after there is a database initialization error in the node::node constructor, it is now checked at the start.

@wezrule wezrule added the bug label May 7, 2019

@wezrule wezrule added this to the V19.0 milestone May 7, 2019

@wezrule wezrule requested a review from argakiig May 7, 2019

@wezrule wezrule self-assigned this May 7, 2019

@zhyatt zhyatt added this to During RC in V19 May 8, 2019

@wezrule wezrule merged commit 1135ba8 into nanocurrency:master May 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:error_when_using_incompatible_ledger_version branch May 8, 2019

@zhyatt zhyatt moved this from During RC to RC 3 (TBD) in V19 May 12, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Stop node when using an incompatible ledger (nanocurrency#1964)
* Stop node when using an incompatible database version

* Give test correct comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.