Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer use bin & lib sub-folders in the installers #1969

Merged
merged 2 commits into from May 9, 2019

Conversation

@wezrule
Copy link
Collaborator

commented May 8, 2019

Thanks to @argakiig for assistance in this task.

This originally came about because the nano_rpc binary was assumed to be in the same folder as nano_node/nano_wallet for the rpc_path generated in config.json to function correctly. This is not currently the case with all the installers. There is a bit of an inconsistency with file placement: Windows has a bin sub-folder containing nano_node & nano_rpc with nano_wallet in the parent folder, while the Xenial linux builds have a bin sub-folder containing all 3. To be consistent I've removed the bin folder and have all binary files in the parent directory.

Also removing the lib folder containing nano_lib.lib as well as it doesn't seem that useful without accompanying header files and will most likely have ABI issues as well.

Have tested Windows/Mac/Ubuntu (Xenial) binary file placements.

The travis build for mac needed to update the cmake version to a minimum of 3.13 as targets cannot be installed which are not in the current directory without it: https://gitlab.kitware.com/cmake/cmake/merge_requests/2152

@argakiig will follow on with any required changes to docker/rpm if required.

@wezrule wezrule added this to the V19.0 milestone May 8, 2019

@wezrule wezrule requested review from argakiig and cryptocode May 8, 2019

@wezrule wezrule self-assigned this May 8, 2019

@wezrule wezrule changed the title Remove bin & lib sub-folders in the installers No longer use bin & lib sub-folders in the installers May 8, 2019

@wezrule wezrule added this to During RC in V19 May 8, 2019

@argakiig argakiig added the universe label May 8, 2019

@wezrule wezrule merged commit f00b8a5 into nanocurrency:master May 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:remove_bin_folder_from_install branch May 9, 2019

@zhyatt zhyatt moved this from During RC to RC 3 (TBD) in V19 May 12, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

No longer use bin & lib sub-folders in the installers (nanocurrency#1969
)

* Remove bin & lib sub-folders

* Upgrade CMake version for travis/mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.