Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific rpc process config options #1977

Merged
merged 1 commit into from May 12, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented May 11, 2019

It wasn't very clear that some of the config options were only applied in certain situations (i.e depending on how the rpc server was run; in-process, child process or out of process). I have made it a bit clearer. The config.json file for instance a new config node (child_process):

    "rpc": {
       ...
        "child_process": {
            "enable": "false",
            "rpc_path": "C:\\Users\\Wesley\\Documents\\raiblocks\\build\\Debug\\nano_rpc.exe"
        }
    }

This only lists things which are child_process specific. If enable is false (default) then it uses the in-process RPC.

rpc_config.json similarly has a new config node for options specific for an rpc server in a different process (child/out of process) rather than being in the main rpc config node:

    "process": {
        "ipc_port": "56000",
        "num_ipc_connections": "4"
    }

@wezrule wezrule added this to the V19.0 milestone May 11, 2019

@wezrule wezrule requested a review from cryptocode May 11, 2019

@wezrule wezrule self-assigned this May 11, 2019

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2019

The "rpc semantics change" label indicates a potentially breaking change for RPC clients, while this is just a config change affecting node operators AFAICT. Maybe we should have a new "configuration" label and general purpose "breaking" and "nonbreaking" labels that can be combined with other labels. Thoughts on that organization @zhyatt ?

@wezrule

This comment has been minimized.

Copy link
Collaborator Author

commented May 11, 2019

Right it's just config changes, and it's still a pre-release change, so will only affect people who have upgraded to the RC already. @cryptocode sometimes I just close my eyes and pick a label :D, I think they could do with a complete rework as a lot has changed since some of these were first introduced.

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2019

Right, asking because we used to use "rpc semantics change" to collect things that could break RPC clients into release notes.

@wezrule wezrule added this to During RC in V19 May 11, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM

@wezrule wezrule merged commit 4fa9271 into nanocurrency:master May 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:rpc_process_sub_config branch May 12, 2019

@zhyatt zhyatt moved this from During RC to RC 3 (TBD) in V19 May 12, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.