Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modify callback to prevent violating boost multiindex invariants #1979

Merged
merged 3 commits into from May 14, 2019

Conversation

3 participants
@cryptocode
Copy link
Collaborator

commented May 12, 2019

We had a crash on master we suspected stemmed from unsynchronized access to a MI container, but it seems everything is protected.

However, udp_channels::modify was empty and the actual modification happened separately. This seems like a likely cause. Added a callback from which the modifications are done.

@cryptocode cryptocode added the bug label May 12, 2019

@cryptocode cryptocode added this to the V19.0 milestone May 12, 2019

@cryptocode cryptocode requested review from clemahieu and wezrule May 12, 2019

@cryptocode cryptocode self-assigned this May 12, 2019

@cryptocode cryptocode added this to During RC in V19 May 12, 2019

@clemahieu clemahieu merged commit 78db0d7 into nanocurrency:master May 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:udp_channels/modify-fix branch May 14, 2019

@zhyatt zhyatt moved this from During RC to RC 3 (TBD) in V19 May 20, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Add modify callback to prevent violating boost multiindex invariants (n…
…anocurrency#1979)

* Add modify callback to prevent violating boost multiindex invariants

* Remove BOOST_MULTI_INDEX_ENABLE_SAFE_MODE

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.