Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize frontiers for background confirmation #1982

Merged

Conversation

@wezrule
Copy link
Collaborator

commented May 14, 2019

Updating the confirmation height for frontiers in the background (in the request loop) takes too long to get the cemented block count close to the total block count currently. The accounts are just searched from lowest account number onwards, which has now been improved by using the request loop wait period to scan through as many accounts as possible and prioritize the ones which have the most uncemented blocks. These are then voted on, which allows more efficient voting traffic as the larger unconfirmed accounts are more likely to confirm other accounts.

Some other parameters have also been modified to make confirming blocks more aggressive when the active root count is low.

@wezrule wezrule added this to the V19.0 milestone May 14, 2019

@wezrule wezrule requested a review from SergiySW May 14, 2019

@wezrule wezrule self-assigned this May 14, 2019

@wezrule wezrule added this to RC 3 (TBD) in V19 May 14, 2019

@zhyatt zhyatt moved this from RC 3 (TBD) to During RC in V19 May 21, 2019

wezrule added some commits May 21, 2019

@zhyatt zhyatt moved this from During RC to RC 4 (TBD) in V19 May 30, 2019

@SergiySW
Copy link
Collaborator

left a comment

LGTM after resolving conflict with master

@wezrule wezrule merged commit 8e515f0 into nanocurrency:master May 31, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:prioritize_frontiers_for_confirming branch May 31, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Prioritize frontiers for background confirmation (#1982)
* Prioritize frontiers for background confirmation

* Remove priority_cemented_* to priority_cementable_*

* When active root transactions are low override the next_frontier_check

* Reduce io

* Formatting

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.