Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite load tester in C++ #1989

Merged
merged 4 commits into from May 16, 2019

Conversation

@wezrule
Copy link
Collaborator

commented May 16, 2019

This solves #1862

Currently the load tester is written in Rust (and is the only thing written in Rust in this repo). It seems like an unnecessary dependency/maintainability headache as most the developers here do not use Rust regularly. It has been rewritten in C++ and is available like all other projects now (part of the CMake build process)

The same output is used to the console and most things have been ported across. The stats and precompute_blocks code has not, the automated tests don't make use of this, and I don't think we have anything which relies on this functionality? Same command line arguments and default are used.

@wezrule wezrule added the tool label May 16, 2019

@wezrule wezrule requested review from argakiig and cryptocode May 16, 2019

@wezrule wezrule self-assigned this May 16, 2019

@wezrule wezrule force-pushed the wezrule:rewrite_load_tester branch from 0818218 to 5ef25cb May 16, 2019

@wezrule wezrule merged commit 04e4eda into nanocurrency:master May 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:rewrite_load_tester branch May 16, 2019

@wezrule wezrule added this to the V19.0 milestone May 16, 2019

@wezrule wezrule added this to RC 3 (TBD) in V19 May 16, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Rewrite load tester in C++ (nanocurrency#1989)
* Rewrite load tester from Rust to C++

* Boost 1.69/mac update

* Rename results to primary_node_results to be more clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.