Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix off by one error in frontier req server #1992
If the wanted count is 1, and you run the code, the following happens:
So the server will send 2 results and then exit if I have understood the code correctly.
There should probably be a test for this as well, but I'm not very good at C++ and I couldn't even get the project to build on my mac, so it's a bit hard to write and check a test..
I see, send_next is initially called from the visitor. This looks like it'll fix it.
I think clients currently always use max here (2^31-1), which might be why tests doesn't pick it up. We can look into fixing the test in a separate PR. The test failure is unrelated, probably one of the tests failing intermittently on CI.