Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up json upgrade code/unused variables #1993

Merged

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented May 16, 2019

Uses the pattern of returning version_a < json_version () everywhere, which should be less error-prone/less code. Also moves the network variable within the ifdef where it's used.

@cryptocode cryptocode added this to the V19.0 milestone May 16, 2019

@cryptocode cryptocode requested a review from wezrule May 16, 2019

@cryptocode cryptocode self-assigned this May 16, 2019

@cryptocode cryptocode added this to RC 3 (TBD) in V19 May 17, 2019

@cryptocode cryptocode merged commit f8da09f into nanocurrency:master May 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:cleanup/unnecessary-variables branch May 17, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.