Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum difficulty for RPC "work_generate" #2006

Merged

Conversation

@SergiySW
Copy link
Collaborator

commented May 21, 2019

to prevent possible OpenCL validation loop
https://github.com/nanocurrency/nano-node/blob/master/nano/node/openclwork.cpp#L698
work_validate is invalid for difficulty < threshold

@SergiySW SergiySW added this to the V19.0 milestone May 21, 2019

@SergiySW SergiySW requested review from wezrule and cryptocode May 21, 2019

@SergiySW SergiySW self-assigned this May 21, 2019

@SergiySW SergiySW added this to During RC in V19 May 21, 2019

@guilhermelawless

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

I don't know about non-breaking... I did use it once :)
I reported that some difficulties below threshold will work, but if it's several orders of magnitude below it hangs.

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

@guilhermelawless yes, probably breaking

@SergiySW SergiySW merged commit f7765c1 into nanocurrency:master May 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt moved this from During RC to RC 3 (TBD) in V19 May 22, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Set minimum difficulty for RPC "work_generate" (nanocurrency#2006)
* Set minimum difficulty for RPC "work_generate"

* Update CLI --debug_opencl for low difficulty
@zhyatt

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

I removed the "rpc semantics change" label as this is reserved for changes that break RPC between official releases. This change only breaks it between RC releases since submitting a work value for work_generate to cause this issue is new with V19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.