Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket fixes and improvements #2007

Merged
merged 1 commit into from May 21, 2019

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented May 21, 2019

Fixes intermittent test failures, as well as buffer life times issues. The IO mutex is removed to follow the pattern of the TCP socket class where everything goes through a strand. Finally, the session cleanup is moved away from message broadcast; this should improve performance a bit if there are many clients.

@cryptocode cryptocode added this to the V19.0 milestone May 21, 2019

@cryptocode cryptocode requested a review from argakiig May 21, 2019

@cryptocode cryptocode self-assigned this May 21, 2019

@zhyatt zhyatt added this to RC 3 (TBD) in V19 May 21, 2019

@cryptocode cryptocode force-pushed the cryptocode:websocket-fix-tests branch from 9bb21b9 to 1a0c322 May 21, 2019

@cryptocode cryptocode merged commit fb093ff into nanocurrency:master May 21, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:websocket-fix-tests branch May 21, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 21, 2019

argakiig added a commit to argakiig/raiblocks that referenced this pull request May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.