Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threshold optional to RPC unopened and ledger #2014

Merged

Conversation

@guilhermelawless
Copy link
Contributor

commented May 22, 2019

RPCs ledger and unopened

Suggested by @renesq , this is an alternative to pagination for lower powered nodes who want information about the ledger (and helps the scalability of this command in the future).

In both cases, the optional count is still honored.

Documentation update needed.

@renesq

This comment has been minimized.

Copy link

commented May 22, 2019

Wondering if we should incorporate the pending balance into this filter's consideration when pending balances are requested. The decision tree would look a bit different then.

@zhyatt zhyatt requested review from wezrule and cryptocode May 23, 2019

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented May 30, 2019

After discussions with @guilhermelawless, we ended up deciding this PR should be updated to include @renesq's idea

@guilhermelawless guilhermelawless force-pushed the guilhermelawless:rpc/heavy-threshold branch from 146ced1 to 8721c81 May 30, 2019

@zhyatt zhyatt added this to the V19.0 milestone May 30, 2019

@zhyatt zhyatt added this to RC 4 (TBD) in V19 May 30, 2019

@cryptocode
Copy link
Collaborator

left a comment

lgtm, pending rebase

@wezrule

wezrule approved these changes Jun 3, 2019

@cryptocode cryptocode merged commit 7484ac9 into nanocurrency:master Jun 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

guilhermelawless added a commit to guilhermelawless/nano-docs that referenced this pull request Jun 3, 2019

zhyatt added a commit to nanocurrency/nano-docs that referenced this pull request Jun 4, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Add threshold optional to RPC unopened and ledger (#2014)
* Add threshold optional to RPC unopened and ledger

* For RPC ledger, if pending is requested, then threshold applies to balance+pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.