Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture SIGINT and SIGTERM to clean up sockets #2018

Merged
merged 2 commits into from Jun 11, 2019

Conversation

@wezrule
Copy link
Collaborator

commented May 22, 2019

This replaces #1845 which got a bit out of date with the new processes.

I wasn't able to reproduce any socket problems when using ctrl + c or kill while any of the processes were running, so was hard for me to test but it didn't make it worse at least. I used the same principle (although a slightly different approach) as @devinus did in the original PR which solves issues he was apparently having with sockets not being cleaned up if abruptly stopping the daemon.

Clearing the transports in ipc_server::stop (a previous review comment) caused some lifetime issues in the async handlers so I have not pursued this currently.

@wezrule wezrule added this to the V19.0 milestone May 22, 2019

@wezrule wezrule requested a review from clemahieu May 22, 2019

@wezrule wezrule self-assigned this May 22, 2019

@wezrule wezrule added this to RC 4 (TBD) in V19 May 25, 2019

@zhyatt zhyatt requested a review from cryptocode Jun 10, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM, handlers called on testing nano_node

@wezrule wezrule merged commit 415dfad into nanocurrency:master Jun 11, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@wezrule wezrule deleted the wezrule:handle_sigterm_and_sigint branch Jun 11, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.