Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out network #2024

Merged
merged 4 commits into from May 24, 2019

Conversation

@SergiySW
Copy link
Collaborator

commented May 23, 2019

Part of #1112

@SergiySW SergiySW added this to the V19.0 milestone May 23, 2019

@SergiySW SergiySW requested review from wezrule and cryptocode May 23, 2019

@SergiySW SergiySW self-assigned this May 23, 2019

@wezrule
Copy link
Collaborator

left a comment

Couple minor points, otherwise LGTM

Show resolved Hide resolved nano/node/network.hpp Outdated
Show resolved Hide resolved nano/node/transport/transport.hpp Outdated

@SergiySW SergiySW requested a review from wezrule May 24, 2019

@SergiySW SergiySW added this to During RC in V19 May 24, 2019

@SergiySW SergiySW merged commit 9eef974 into nanocurrency:master May 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt moved this from During RC to RC 4 (TBD) in V19 May 27, 2019

argakiig added a commit that referenced this pull request Jun 11, 2019

Factor out network (#2024)
* Factor out network (part of #1112)
* Apply review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.